Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support nested children #735

Merged
merged 1 commit into from
Dec 27, 2017
Merged

Conversation

theKashey
Copy link
Collaborator

This will solve #279 (not decorators, but test case).
The issue is very popular in react world

<Layout><A/><B/></Layout>
const Layout = ({children}) => <div><h1/>{children}</div>

The problem - children can be

  1. A multy dimension array (React 15/16)
  2. Object with children, and type:null (Enzyme???)

This PR solves a problem with merging complex structure as children, and able to reconcile decorated class in a complex environment.

@codecov-io
Copy link

codecov-io commented Dec 27, 2017

Codecov Report

Merging #735 into next will increase coverage by 4.14%.
The diff coverage is 91.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next     #735      +/-   ##
==========================================
+ Coverage   71.42%   75.57%   +4.14%     
==========================================
  Files          12       12              
  Lines         420      434      +14     
  Branches       92      105      +13     
==========================================
+ Hits          300      328      +28     
+ Misses        102       87      -15     
- Partials       18       19       +1
Impacted Files Coverage Δ
...-hot-loader/src/reconciler/hotReplacementRender.js 87.73% <91.89%> (+10.54%) ⬆️
...ages/react-hot-loader/src/reconciler/reactUtils.js 84.61% <0%> (ø) ⬆️
...es/react-hot-loader/src/reconciler/reactHydrate.js 55.76% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73ba25b...357ae04. Read the comment docs.

@gregberge gregberge merged commit 5c81655 into gaearon:next Dec 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants