Swallow the error during the hot-render phase.

[theKashey]

try...finally does not catch the error, one should catch it in real.

As result "the error" before and after HRM has the same behavior. We do not changing it now.

[codecov-io]

Codecov Report

Merging #814 into next will increase coverage by 0.06%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##             next     #814      +/-   ##
==========================================
+ Coverage   84.31%   84.38%   +0.06%     
==========================================
  Files          23       23              
  Lines         491      493       +2     
  Branches      135      138       +3     
==========================================
+ Hits          414      416       +2     
+ Misses         60       59       -1     
- Partials       17       18       +1

Impacted Files	Coverage Δ
...-hot-loader/src/reconciler/hotReplacementRender.js	87.17% <100%> (-0.39%)	⬇️
packages/react-hot-loader/src/logger.js	11.11% <0%> (-11.12%)	⬇️
packages/react-hot-loader/src/AppContainer.dev.js	80% <0%> (+10%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 843cd5d...e1d99f5. Read the comment docs.

[gregberge]

Coverage is decreasing, can you add a little test for this?

[gregberge]

Hmm, and why not throw it instead of logging?

[theKashey]

Cos error should be thrown by real render. And it should be thrown in the real render.