Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break cyclic dependency #822

Merged
merged 1 commit into from
Jan 25, 2018
Merged

Break cyclic dependency #822

merged 1 commit into from
Jan 25, 2018

Conversation

theKashey
Copy link
Collaborator

Logger uses react-hot-loader(to get flags), which uses proxies, which uses logger to inject logger into stand-in.
As result it injects null, and stand-in will throw an NPE instead of logging anything.

@codecov-io
Copy link

Codecov Report

Merging #822 into next will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next     #822      +/-   ##
==========================================
+ Coverage   84.85%   84.92%   +0.06%     
==========================================
  Files          23       23              
  Lines         515      504      -11     
  Branches      129      140      +11     
==========================================
- Hits          437      428       -9     
+ Misses         59       56       -3     
- Partials       19       20       +1
Impacted Files Coverage Δ
...ackages/react-hot-loader/src/reconciler/proxies.js 97.72% <ø> (+1.36%) ⬆️
packages/react-hot-loader/src/utils.dev.js 100% <100%> (+25%) ⬆️
...ckages/react-hot-loader/src/internal/reactUtils.js 92.3% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f2e01f...b51f1c1. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants