Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix proxy adapter #842

Merged
merged 1 commit into from
Feb 5, 2018
Merged

Fix proxy adapter #842

merged 1 commit into from
Feb 5, 2018

Conversation

theKashey
Copy link
Collaborator

Beta-20 is a bit broken. This PR will fix #841.
@neoziro I propose to merge this one, and draft beta-21.

Not adding tests for this code, to not cause merge conflicts with your branch.

@codecov-io
Copy link

codecov-io commented Feb 5, 2018

Codecov Report

Merging #842 into next will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             next     #842   +/-   ##
=======================================
  Coverage   86.21%   86.21%           
=======================================
  Files          25       25           
  Lines         573      573           
  Branches       95      153   +58     
=======================================
  Hits          494      494           
+ Misses         68       59    -9     
- Partials       11       20    +9
Impacted Files Coverage Δ
...es/react-hot-loader/src/reconciler/proxyAdapter.js 94.44% <100%> (ø) ⬆️
...ot-loader/src/internal/stack/hydrateLegacyStack.js 8.69% <0%> (ø) ⬆️
packages/react-hot-loader/src/global/modules.js 74.19% <0%> (ø) ⬆️
...-hot-loader/src/reconciler/hotReplacementRender.js 87.72% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d29f484...a824ddb. Read the comment docs.

@gregberge
Copy link
Collaborator

gregberge commented Feb 5, 2018 via email

@gregberge gregberge merged commit 9bb8251 into next Feb 5, 2018
@gregberge gregberge deleted the fix-proxy-adapter branch February 5, 2018 08:22
theKashey added a commit that referenced this pull request Feb 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants