Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

break render recursion, fix #882 #889

Merged
merged 1 commit into from
Mar 22, 2018
Merged

Conversation

theKashey
Copy link
Collaborator

Just breaking .render into two methods, calling the second one in subrender, to prevent MobX from render call recursion.

@theKashey theKashey requested a review from gregberge March 8, 2018 12:33
@codecov-io
Copy link

Codecov Report

Merging #889 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #889      +/-   ##
==========================================
+ Coverage   87.38%   87.42%   +0.03%     
==========================================
  Files          30       30              
  Lines         634      636       +2     
  Branches      148      149       +1     
==========================================
+ Hits          554      556       +2     
  Misses         64       64              
  Partials       16       16
Impacted Files Coverage Δ
src/reconciler/hotReplacementRender.js 85.31% <100%> (ø) ⬆️
src/proxy/createClassProxy.js 99.03% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b639bc6...33f2376. Read the comment docs.

@theKashey theKashey merged commit ef42058 into master Mar 22, 2018
@gregberge gregberge deleted the break-recursion-render branch March 23, 2018 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants