New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limiting RHL (Winter is coming) #991
Comments
|
It wouldn’t be reasonable to ask components that need to not be hot, to add a dep on react-got-loader. Any mechanism for this should be something that doesn’t require adding this dep. |
I love the idea! |
@ljharb - by default all your components could be changed and hot-reloaded, and all thirdparty could not be changed, and thus we probably shall disable RHL for them, to lower side effects (type comparison, for example). The only problem - it will not work out of the box, cos 99% babel setups excludes node_modules. |
@theKashey yes, that’s true. But if hot loader won’t choose to be safe out of the box, then it seems right to offer an output that minimally inconveniences third parties. |
I am just not activating this untested feature out of the box, yet. And that is ok, as long it does not change the default RHL behavior. |
fixed in v4.3.0 |
User request:
Doable, but we could improve it - for example not proxy any components from node_modules, as long they should be considered static. (see #304 (comment))
Way to reproduce:
hothow
to all components with origin in node_modulesThe text was updated successfully, but these errors were encountered: