3.x fails when the class contains non-configurable properties

[gaearon]

We should add a try-catch there or be more careful copying descriptors.

[danibrear]

Hey Dan, I wanted to try my hand at this, do you mind adding a little bit more information about how you're getting it to fail?

[gaearon]

I think something like this

class Stuff extends Component {
  render() { return <div /> }
}
Object.defineProperty(Stuff, {
  configurable: false,
  value: 42
})

and try to patch that up with a new version. I think you can tweak static-descriptors test cases to repro this.

[dbo]

Excuse my ignorance, but shouldn't this issue also cover non-writable properties like prototype.constructor? I am defining the constructor property as read only out of good habit. Hot reloading breaks when it is patched here: https://github.com/gaearon/react-proxy/blob/next/src/createClassProxy.js#L216