Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report example #10

Open
gael-boyenval opened this issue Mar 31, 2023 · 0 comments
Open

report example #10

gael-boyenval opened this issue Mar 31, 2023 · 0 comments

Comments

@gael-boyenval
Copy link
Owner

Debt collector report

βœ… Debt score for modified files decreased by -215 1

You did great ! πŸŽ‰

Previous debt Current debt trend
358 143 -215

Modified files β€’ see scores before and after

πŸ’€ Files with same debt :

File Prev Current Trend
packages/app-cdc-catalog/src/c....nalizationSection.module.scss 3 3 =
packages/app-cdc-catalog/src/c....Product/Product.container.tsx 2 2 =
packages/app-cdc-catalog/src/c....asses/VirtualTryOnGlasses.tsx 1 1 =
packages/app-cdc-catalog/src/pages/_app.tsx 2 2 =
packages/app-cdc-catalog/src/redux/content/helpers.ts 22 22 =
packages/app-cdc-catalog/src/v....AccountPanel/AccountPanel.tsx 1 1 =
packages/app-cdc-catalog/src/v....getHeaderAccountPanelItems.ts 3 3 =
packages/app-cdc-catalog/src/v....Actions/Actions.container.tsx 23 23 =
packages/app-cdc-checkout/src/....ricSection/GenericOptions.tsx 3 3 =
packages/app-pcd-catalog/src/v....st/WishlistItem.container.tsx 1 1 =
packages/app-pcd-catalog/src/v....y/TopContentBeautyDesktop.tsx 7 7 =
packages/app-pcd-catalog/src/v....ty/TopContentBeautyMobile.tsx 7 7 =
packages/app-pcd-checkout/src/....rderPageDetails.container.tsx 2 2 =
packages/app-pcd-checkout/src/....CybersourcePayPal.module.scss 5 5 =
packages/lib-pcd-cart/src/comp....tButtons/CheckoutButtons.scss 2 2 =
packages/lib-pcd-cart/src/comp....GooglePayButtonWithParams.tsx 1 1 =
packages/lib-pcd-cart/src/comp....ms/PaypalButtonWithParams.tsx 1 1 =
packages/lib-pcd-cart/src/comp....ypalPopin/PostPaypalPopin.tsx 1 1 =
packages/lib-pcd-cart/src/helpers/checkoutEndpoints.ts 6 6 =
packages/lib-pcd-cart/src/stories/decorators.tsx 1 1 =

βœ… Files with less debt :

File Prev Current Trend
packages/app-cdc-catalog/src/c....roductLightCard.container.tsx 3 0 β–Ό -3
packages/app-cdc-catalog/src/c..../ProductLightCard.module.scss 8 0 β–Ό -8
packages/app-cdc-catalog/src/c....eWishlistLegacy.container.tsx 7 0 β–Ό -7
packages/app-cdc-catalog/src/c....gleWishlistLegacy.module.scss 2 0 β–Ό -2
packages/app-cdc-catalog/src/m....msContentWithStockPriceApi.ts 19 18 β–Ό -1
packages/app-cdc-catalog/src/redux/epics.ts 1 0 β–Ό -1
packages/app-cdc-catalog/src/redux/selectors.ts 5 4 β–Ό -1
packages/app-cdc-catalog/src/redux/stocks/mw.ts 1 0 β–Ό -1
packages/app-cdc-catalog/src/redux/stocks/reducer.ts 2 0 β–Ό -2
packages/app-cdc-catalog/src/redux/wishlist/helpers.ts 12 0 β–Ό -12
packages/app-cdc-catalog/src/redux/wishlist/mw.ts 8 0 β–Ό -8
packages/app-cdc-catalog/src/redux/wishlist/reducer.ts 22 0 β–Ό -22
packages/app-cdc-catalog/src/redux/wishlist/selectors.ts 16 0 β–Ό -16
packages/app-cdc-catalog/src/v....derAccountPanel.container.tsx 2 0 β–Ό -2
packages/app-cdc-catalog/src/v....t/EmptyWishlist.container.tsx 1 0 β–Ό -1
packages/app-cdc-catalog/src/v....st/WishlistItem.container.tsx 1 0 β–Ό -1
packages/app-cdc-catalog/src/v....list/WishlistItem.module.scss 16 0 β–Ό -16
packages/app-cdc-catalog/src/v....nel/Wishlist/WishlistItem.tsx 4 0 β–Ό -4
packages/app-cdc-catalog/src/v....hlistItemBeauty.container.tsx 8 0 β–Ό -8
packages/app-cdc-catalog/src/v....listItemCouture.container.tsx 8 0 β–Ό -8
packages/app-cdc-catalog/src/v....ist/WishlistItems.module.scss 1 0 β–Ό -1
packages/app-cdc-catalog/src/v..../WishlistLegacy.container.tsx 14 0 β–Ό -14
packages/app-cdc-catalog/src/v....ersonalizationBundle/utils.ts 57 27 β–Ό -30
packages/app-cdc-catalog/src/v....r/ProductSlider.container.tsx 1 0 β–Ό -1
packages/app-cdc-catalog/src/v....der/ProductSlider.module.scss 12 0 β–Ό -12
packages/app-cdc-catalog/src/v....ProductPushSlider.module.scss 10 0 β–Ό -10
packages/app-cdc-catalog/src/v....SliderWithInfos.container.tsx 2 0 β–Ό -2
packages/app-cdc-catalog/src/v....ctSliderWithInfos.module.scss 5 0 β–Ό -5
packages/app-cdc-catalog/src/v....ProductsSelection.module.scss 4 0 β–Ό -4
packages/app-cdc-catalog/src/v....tsSelectionSlider.module.scss 3 0 β–Ό -3
packages/app-pcd-catalog/src/v....listItemCouture.container.tsx 8 0 β–Ό -8
packages/app-pcd-checkout/src/....gForLoggedInForFulfilments.ts 1 0 β–Ό -1


Help us improve code quality! Here are some ideas for you



packages/app-cdc-catalog/src/core/compon....tion/PersonalizationSection.module.scss

Broken rule score
🚫 remove useless :global and apply classes using "styles.myClassName" instead 2
🚫 rewrite BEM classe names into kebab-case notation 1


packages/app-cdc-catalog/src/core/components/Product/Product.container.tsx

Broken rule score
🚫 Use Optional chaining (obj?.key) instead of lodash.property 2


packages/app-cdc-catalog/src/core/compon....ualTryOnGlasses/VirtualTryOnGlasses.tsx

Broken rule score
🚫 Use native Array.filter instead of lodash.filter 1


packages/app-cdc-catalog/src/map/mapCmsContentWithStockPriceApi.ts

Broken rule score
🚫 Use Array.map instead of lodash.map 7
🚫 Use Optional chaining (obj?.key) instead of lodash.property 11


packages/app-cdc-catalog/src/pages/_app.tsx

Broken rule score
🚫 Use Optional chaining (obj?.key) instead of lodash.property 2


packages/app-cdc-catalog/src/redux/content/helpers.ts

Broken rule score
🚫 Use Array.map instead of lodash.map 6
🚫 Use Optional chaining (obj?.key) instead of lodash.property 15
🚫 Use native Array.reduce instead of lodash.reduce 1


packages/app-cdc-catalog/src/redux/selectors.ts

Broken rule score
🚫 Use Optional chaining (obj?.key) instead of lodash.property 4


packages/app-cdc-catalog/src/views/AccountPanel/AccountPanel.tsx

Broken rule score
🚫 Use Optional chaining (obj?.key) instead of lodash.property 1


packages/app-cdc-catalog/src/views/Accou....l/helpers/getHeaderAccountPanelItems.ts

Broken rule score
🚫 Use Optional chaining (obj?.key) instead of lodash.property 3


packages/app-cdc-catalog/src/views/LandingPage/PersonalizationBundle/utils.ts

Broken rule score
🚫 Use Array.map instead of lodash.map 11
🚫 Use native Array.filter instead of lodash.filter 2
🚫 Use Optional chaining (obj?.key) instead of lodash.property 10
🚫 Use native Array.reduce instead of lodash.reduce 1
🚫 Use native Array.find instead of lodash.find 3


packages/app-cdc-catalog/src/views/Produ....e/Couture/Actions/Actions.container.tsx

Broken rule score
🚫 use useTrackOnClick instead of withTrackOnClick 1
🚫 Use useAddedToCartPopin hook instead of withAddedToCartPopin 1
🚫 Use SelectedVariation context instead of withSelectedVariation 1
🚫 Remove withDiorContext and use DiorContext instead 1
🚫 Remove withPickedQueryParams and use usePickedQueryParams instead 1
🚫 Remove withUniverseWording, withWording, withDynamicKeyWording and withDynamicWording and use useWording instead 4
🚫 Use Array.map instead of lodash.map 5
🚫 Use Optional chaining (obj?.key) instead of lodash.property 9


packages/app-cdc-checkout/src/components....tPage/GenericSection/GenericOptions.tsx

Broken rule score
🚫 Delete @ts-expect-error comments 3


packages/app-pcd-catalog/src/views/Accou....nel/Wishlist/WishlistItem.container.tsx

Broken rule score
🚫 Remove withDiorContext and use DiorContext instead 1


packages/app-pcd-catalog/src/views/Produ....ntentBeauty/TopContentBeautyDesktop.tsx

Broken rule score
🚫 Use Optional chaining (obj?.key) instead of lodash.property 1
🚫 Delete @ts-expect-error comments 6


packages/app-pcd-catalog/src/views/Produ....ontentBeauty/TopContentBeautyMobile.tsx

Broken rule score
🚫 Use Optional chaining (obj?.key) instead of lodash.property 1
🚫 Delete @ts-expect-error comments 6


packages/app-pcd-checkout/src/components....rderPage/OrderPageDetails.container.tsx

Broken rule score
🚫 Delete @ts-expect-error comments 2


packages/app-pcd-checkout/src/components....al/PaymentCybersourcePayPal.module.scss

Broken rule score
🚫 remove useless :global and apply classes using "styles.myClassName" instead 4
🚫 rewrite BEM classe names into kebab-case notation 1


packages/lib-pcd-cart/src/components/CheckoutButtons/CheckoutButtons.scss

Broken rule score
🚫 use css modules and import styles from "style.module.scss" instead of global stylesheets 1
🚫 rewrite BEM classe names into kebab-case notation 1


packages/lib-pcd-cart/src/components/Goo....ithParams/GooglePayButtonWithParams.tsx

Broken rule score
🚫 Delete @ts-expect-error comments 1


packages/lib-pcd-cart/src/components/Pay....onWithParams/PaypalButtonWithParams.tsx

Broken rule score
🚫 Delete @ts-expect-error comments 1


packages/lib-pcd-cart/src/components/PostPaypalPopin/PostPaypalPopin.tsx

Broken rule score
🚫 Use Optional chaining (obj?.key) instead of lodash.property 1


packages/lib-pcd-cart/src/helpers/checkoutEndpoints.ts

Broken rule score
🚫 Use Optional chaining (obj?.key) instead of lodash.property 6


packages/lib-pcd-cart/src/stories/decorators.tsx

Broken rule score
🚫 Delete @ts-expect-error comments 1


Footnotes

  1. Scores based on modified files only
    The report may not be accurate if your branch is not up to date with the base branch. ↩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant