Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EFIT Mapping Definition Is Not Parsed Correctly #230

Closed
torrinba opened this issue Feb 11, 2023 · 5 comments
Closed

EFIT Mapping Definition Is Not Parsed Correctly #230

torrinba opened this issue Feb 11, 2023 · 5 comments
Assignees
Labels

Comments

@torrinba
Copy link
Collaborator

For some reason the _efit.json file is not parsed correctly. When the mapping is loaded (opened dynamically and then the path is evaluated), a strange error occurs

LookupError: Not a valid IMAS 3.38.1 location: equilibrium.time_slice.0.profiles_2d.0.grid._type
                                                                                                                                             ^^^^^
Did you mean: dim2_error_upper, dim1_error_upper, volume_element_error_upper, volume_element, volume_element_error_lower, ...

This is caused by

"equilibrium.time_slice.:.profiles_2d.:.grid_type.index": {
and when that block is removed the error no longer occurs.

@orso82
Copy link
Member

orso82 commented Feb 13, 2023

@bechtt I cannot seem to be able to reproduce this issue, at least with this piece of code.

from omas import *

ods = ODS()
with ods.open("d3d", 133221):
    print(ods["equilibrium.time_slice.:.profiles_2d.:.grid_type.index"])

@torrinba
Copy link
Collaborator Author

torrinba commented Feb 13, 2023

Thanks for trying that out. I agree that directly executing the ods does not produce any issues. After more testing this appears to be related to the paths method that you fixed in https://github.com/gafusion/omas/tree/paths_dynamic. When I am testing on the mapping fix PR #226 this code produces the error:

from omas import *

ods = ODS()
ods.open("d3d", 133221)
ods.paths()

Unfortunately other errors are encountered first if you are on a different branch.

@torrinba
Copy link
Collaborator Author

@orso82 the change in 6fb175f appears to have broken machine mappings completely. ods.open("d3d", 133221) is now returning an empty ODS

@orso82
Copy link
Member

orso82 commented Feb 14, 2023

Ok, try again b700fa4

@torrinba
Copy link
Collaborator Author

That solves it! I don't see any more problems with the machine mapping for DIII-D. Thanks for working through all of them with me

@orso82 orso82 closed this as completed in 6fb175f Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants