Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minDeltaPsi default #49

Closed
gevro opened this issue May 28, 2020 · 4 comments
Closed

minDeltaPsi default #49

gevro opened this issue May 28, 2020 · 4 comments

Comments

@gevro
Copy link

gevro commented May 28, 2020

The default config.yaml created by 'drop init' sets minDeltaPsi to 0. However your documentation says the default should be 0.05.

Which value should it be?

@vyepez88
Copy link
Collaborator

This parameter removes junctions with no (or little) variability as, anyway, no outliers will be detected on them, and the fit will be faster. I updated the default of drop init to 0.05

@gevro
Copy link
Author

gevro commented May 28, 2020

Is it possible if only 1 sample out of 100 samples is an outlier that mindeltaPsi - 0.05 will miss this abnormal sample splicing? That is an important situation not to miss for rare disease research.

@vyepez88
Copy link
Collaborator

Yes, if all samples has a deltaPsi of 0 and 1 sample has a deltaPsi of 0.05, it can be called as an outlier. Nevertheless, a splicing defect of 0.05 might not be strong enough to cause a disease. Our deltaPsi cutoff for a junction to be significant is 0.3. Nevertheless, we left them as parameters so that users can adjust them as they prefer.

@gevro
Copy link
Author

gevro commented May 28, 2020

I see. I was confused how mindeltaPsi is calculated. If it was an average across all samples, then one sample wouldn't be detected, but I guess it is calculated relative to single samples and not an average across all samples.

@gevro gevro closed this as completed May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants