Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/module refresh for manually imported modules #699

Merged
merged 11 commits into from
May 21, 2022

Conversation

juwit
Copy link
Member

@juwit juwit commented Mar 4, 2022

Description

This PR allows module refresh for manually imported modules by analysing the module URL to determine the registry/projet id (especially for gitlab project ids).

Checklist for the pull request author

  • Tests added for this feature
  • Commit messages follow conventions (see CONTRIBUTING.md)
  • Commits are combined ( 1 commit / type and scope )
  • Documentation created / updated (if necessary)
  • No new sonarqube issues added
  • CI pipeline is OK
  • Pull request is fast-forward to the main branch
  • The last commit of this merge request :
    • updates the pom.xml to a new minor or major version
    • updates the CHANGELOG.md

Checklist for the project maintainer

  • Review the code, and add a Review Approval if everything is ok
  • This pull request will be merged in merge-commit mode

After the merge

  • Put the tag on the merged commit
  • Follow the pipeline for the tag, which should build & release the package (maven or docker)

Issues / Links

@juwit juwit requested a review from cdubuisson March 4, 2022 17:37
@juwit juwit added ✨ feature:modules module list & module edition 👌 ready for review The pull request is ready for review labels Mar 4, 2022
@sonarcloud
Copy link

sonarcloud bot commented Mar 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

83.3% 83.3% Coverage
0.0% 0.0% Duplication

@cdubuisson cdubuisson self-assigned this May 6, 2022
@juwit juwit force-pushed the feature/module-refresh-for-manually-imported-modules branch from 0a17b91 to d37e1f3 Compare May 6, 2022 15:50
cdubuisson
cdubuisson previously approved these changes May 6, 2022
@juwit juwit force-pushed the feature/module-refresh-for-manually-imported-modules branch 3 times, most recently from c26cda4 to 0e6f353 Compare May 8, 2022 07:19
cdubuisson
cdubuisson previously approved these changes May 9, 2022
@juwit juwit force-pushed the feature/module-refresh-for-manually-imported-modules branch from 0e6f353 to da01f1b Compare May 21, 2022 09:13
@sonarcloud
Copy link

sonarcloud bot commented May 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

83.3% 83.3% Coverage
0.0% 0.0% Duplication

@cdubuisson cdubuisson merged commit 57e49d3 into main May 21, 2022
@cdubuisson cdubuisson deleted the feature/module-refresh-for-manually-imported-modules branch May 21, 2022 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ feature:modules module list & module edition 👌 ready for review The pull request is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 : Exception at manual module refresh
2 participants