[accessibility] add aria-hidden for icons so Screen Reader will ignore them #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| this.makeAccessible(); | ||
| // offload the initiate operation to save loadtime | ||
| setTimeout(() => { | ||
| this.makeAccessible(); |
There was a problem hiding this comment.
Can you give more detail in this comment. IE. What is expensive?
NIT: setTimeout(() => this.makeAccessible());
|
put |
gasolin
force-pushed
the
a11y
branch
2 times, most recently
from
34c465a
to
126d498
Compare
|
test script is available in #15 |
| @@ -31,11 +31,21 @@ module.exports = component.register('gaia-list', { | |||
| this.setupShadowRoot(); | |||
| this.els = { inner: this.shadowRoot.querySelector('.inner') }; | |||
| this.addEventListener('click', this.onPointerDown); | |||
| this.makeAccessible(); | |||
| // put non-critical operations in post-load time frame | |||
| // to save loadtime. | |||
There was a problem hiding this comment.
Can we explain why this is faster
gasolin
force-pushed
the
a11y
branch
2 times, most recently
from
855a5ff
to
06f1f6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.