Make gaia-progress be WAI-ARIA progressbar #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My changes are same as the previous PR (#1). |
| @@ -19,6 +19,9 @@ module.exports = component.register('gaia-progress', { | |||
| inner: this.shadowRoot.querySelector('.inner'), | |||
| bar: this.shadowRoot.querySelector('.bar'), | |||
| }; | |||
| this.els.inner.setAttribute("role", "progressbar"); | |||
There was a problem hiding this comment.
NIT: Extra line-break above this line
|
Thank you for your review. I addressed coding style issues. |
|
Perfect thanks :) Can you 'squash'* your commits into one and I'll press the merge button. *You'll need to use an 'interactive rebase' something like |
|
Thank you for your review. I squashed my commits. |
wilsonpage
added a commit
that referenced
this pull request
Jan 26, 2015
Make gaia-progress be WAI-ARIA progressbar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec: