Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The tests aren't cleaning up after themselves #10

Closed
Skarlso opened this issue Jul 8, 2018 · 3 comments
Closed

The tests aren't cleaning up after themselves #10

Skarlso opened this issue Jul 8, 2018 · 3 comments

Comments

@Skarlso
Copy link
Member

Skarlso commented Jul 8, 2018

When I run go test a bunch of things are left under pipeline that pollute the work tree.

~/golang/src/github.com/gaia-pipeline/gaia makefile_refactor* 10s
❯ git status
On branch makefile_refactor
Your branch is up-to-date with 'skarlso/makefile_refactor'.

Untracked files:
  (use "git add <file>..." to include in what will be committed)

	pipeline/.circleci/
	pipeline/.gitignore
	pipeline/.goreleaser.yml
	pipeline/Gopkg.lock
	pipeline/Gopkg.toml
	pipeline/LICENSE
	pipeline/Makefile
	pipeline/README.rst
	pipeline/cmd/
	pipeline/docker/
	pipeline/frontend/
	pipeline/gaia.go
	pipeline/handlers/
	pipeline/pipeline/
	pipeline/plugin/
	pipeline/scheduler/
	pipeline/store/
	pipeline/vendor/
@michelvocks
Copy link
Member

I'm actually a bit ashamed of the tests. 😣
They are really messed up and most times they are not working.

@Skarlso
Copy link
Member Author

Skarlso commented Jul 8, 2018

Don't worry about it. :) I'll clean them up as I go through them. ;)

@Skarlso
Copy link
Member Author

Skarlso commented Jul 8, 2018

Fixed by #12

@Skarlso Skarlso closed this as completed Jul 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants