Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portable launcher should assume that it already has the engine and not try to download it #19

Closed
ForbodingAngel opened this issue Jan 21, 2020 · 2 comments

Comments

@ForbodingAngel
Copy link

The current method is a setup for failure that is tied to an arbitrary "has it been deleted yet?" spring build deletion cycle.

The entire point of portable is to be self contained insomuch that is has the base game and engine distributed with it (ignoring the fact that checking for game/luamenu updates happen upon launch <- this is to be expected). So it doesn't make sense for the launcher to fail because it's checking for an engine build it already has.

Portable shouldn't be trying to download the engine at all. If you are using the portable build then it is clear and should be obvious that that comes with maintenance responsibilities.

@gajop
Copy link
Owner

gajop commented Jan 21, 2020

If you don't want it to download the engine, then just remove the engine from the list of downloads for the portable build: https://github.com/EvolutionRTS/EvoRTS-Chobby/blob/master/dist_cfg/config.json#L40 ?

This doesn't merit an issue - unlike your original problem ("launcher tries to download something that already exists"), which is worth fixing

@gajop gajop closed this as completed Jan 21, 2020
@ForbodingAngel
Copy link
Author

So in other words:

This is already doable. All you have to do is remove the engine from the downloads list in your game's chobby repo in dist_cfg/config.json

Awesome, thanks for the info :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants