Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: logging #25

Merged
merged 1 commit into from Nov 30, 2016
Merged

fix: logging #25

merged 1 commit into from Nov 30, 2016

Conversation

laggingreflex
Copy link
Contributor

@laggingreflex laggingreflex commented Nov 29, 2016

edit: original PR withdrawn

before:

[03:26:10] <...>\src\utils\index.js [index have not changed]
[03:26:10] <...>\src\methods\index.js [index have not changed]
[03:26:10] <...>\src\utils\prompt\index.js [index have not changed]
[03:26:10] <...>\src\utils\help\index.js [index have not changed]
[03:26:10] <...>\src\utils\error\index.js [index have not changed]

after:

[03:22:25] [index created] <...>\src\utils\index.js
[03:22:25] [index is same] <...>\src\methods\index.js
[03:22:25] [index is same] <...>\src\utils\prompt\index.js
[03:22:26] [index is same] <...>\src\utils\help\index.js
[03:22:26] [index updated] <...>\src\utils\error\index.js

@gajus
Copy link
Owner

gajus commented Nov 30, 2016

I am happy to change the position of the tag. However, I'd like to keep the full phrasing.

@laggingreflex
Copy link
Contributor Author

laggingreflex commented Nov 30, 2016

Would this phrasing work better?

      index have not changed
      index has been updated
      created a new index.js

edit: updated PR

@gajus
Copy link
Owner

gajus commented Nov 30, 2016

Please use:

index has not changed
index has been changed
create a new index.js

Use pad-right to align the lines. (I am assuming thats your intention with this PR.)

That said, I don't see much value in aligning the console output (aligning the output is job of whatever filters you use to view the logs).

@laggingreflex
Copy link
Contributor Author

Pad-right sounds much better solution to what I was trying to do (yes, alignment was my main goal). But now that you've put it that way, I'm too considering not giving it much value or using other logging tools that might probably do better job and handle more cases. So I wouldn't wanna use pad-right if it's gonna be just for the sake of it.

I'm happy to leave it as it was before. With just a minor correction this time.

index has not changed  // have (originally) -> has
updated index // what it was originally, shorter is much better if it's gonna be on the right
created index // ``ditto. 

@gajus
Copy link
Owner

gajus commented Nov 30, 2016

index has not changed  // have (originally) -> has
updated index // what it was originally, shorter is much better if it's gonna be on the right
created index // ``dit

Sounds good.

@gajus gajus merged commit 2bafc5b into gajus:master Nov 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants