-
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement rule equivalent to "show-errors" in eslint-plugin-flowtype-errors? #166
Comments
@danharper thoughts? |
Are you proposing merging the plugins if they'd be happy with it? Wouldn't want to duplicate effort otherwise. It looks like the plugin no longer installs Flow itself, and relies on a peerDep instead. |
Adding to my original comment:
|
Tbf, I feel the same way. Let's keep not worry about it then? |
@danharper, @thejameskyle approached me via email suggesting the idea of merging the two. I assume he approached @amilajack with an equivalent proposal. My answer was that that I have quoted. |
If there is demand for it though, I'd rather discovery & configuration be easy for users, so merging would make sense. |
Thats what I am thinking too. The biggest pro is that it would potentially attract more people to use this plugin. More people using the plugin = more visibility = more potential contributors to the code base. |
I was not approached about this. My thoughts on this are that it should be merged but it should be disabled by default. That would make it easy for editors without flow support to have support. Also I'm not sure if this is just me but when using IDE/text editor plugins for flow, I've noticed high CPU usage (all cores at 100%) on my MacBook Pro 2014. I've tried Nuclide, flow-ide, and ide-flow Also if this project decides to merge eslint-plugin-flowtype, I would recommend doing so after these issues are fixed:
So I would say:
|
I used to get it a lot with IntelliJ, however it's calmed down recently. Still happens every now and then, though. |
@amilajack Thank you for your follow up.
Please raise a PR incorporating the changes, when you will you are ready. I'd be happy to make you a collaborator in the project. Most of the work recently has been carried out by @danharper, I'd like you to collaborate on future releases. That is, if you are interested? |
I'm not that great with regex but I'll help with anything that I can. Also what do you think about keeping the project separate? I think Thoughts? |
Absolutely. I will have a look into whats the best way to extend an existing plugin in this way. Unless you are already familiar with the steps? |
No worries. I'll make a PR for this. Just wanted to confirm extending the plugin is the right way to go. |
Would there be interest to implement a rule equivalent to "show-errors" in https://github.com/amilajack/eslint-plugin-flowtype-errors?
There appears to be a measurable demand (https://github.com/amilajack/eslint-plugin-flowtype-errors/graphs/contributors) for implementing Flow error reporting via ESLint.
Pros:
Cons:
eslint-plugin-flowtype
setupFlow (flow-bin) would need to be installed either as a dependency of
eslint-plugin-flowtype
(making this package a lot heavier) or user would need to install Flow separately (the approach thateslint-plugin-flowtype-errors
is taking).The text was updated successfully, but these errors were encountered: