Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sort-keys fails when there is a spread object #287

Closed
kalley opened this issue Nov 15, 2017 · 1 comment · Fixed by #326
Closed

sort-keys fails when there is a spread object #287

kalley opened this issue Nov 15, 2017 · 1 comment · Fixed by #326
Labels
bug help wanted

Comments

@kalley
Copy link

kalley commented Nov 15, 2017

When there is a ObjectTypeSpreadProperty in a object that is being sorted it fails at https://github.com/gajus/eslint-plugin-flowtype/blob/master/src/rules/sortKeys.js#L78 because there is no value.
@gajus
Copy link
Owner

gajus commented Nov 15, 2017

PR welcome.

@frodosamoa frodosamoa mentioned this issue Apr 20, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: support fixing sort keys with ObjectTypeSpreadProperty frodosamoa/eslint-plugin-flowtype
2 participants
@kalley @gajus