Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new lint errors now occurring #422

Merged
merged 1 commit into from
Jul 28, 2019
Merged

Conversation

lukeapage
Copy link
Contributor

I started trying to make changes but lint fails, because https://github.com/gajus/eslint-config-canonical/releases/tag/v17.2.0 causes a whole load of errors on a new npm install.
This PR just runs eslint --fix and commits it.

@lukeapage lukeapage changed the title run lint fix after npm install Fix new lint errors now occurring Jul 28, 2019
@gajus gajus merged commit 2981c01 into gajus:master Jul 28, 2019
@gajus
Copy link
Owner

gajus commented Jul 28, 2019

🎉 This PR is included in version 3.12.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gajus gajus added the released label Jul 28, 2019
@lukeapage
Copy link
Contributor Author

@gajus not sure if you noticed but 4 failures were merged after this so the master build currently fails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants