Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [sort-keys] handle method signatures #459

Merged
merged 2 commits into from Feb 18, 2021
Merged

fix: [sort-keys] handle method signatures #459

merged 2 commits into from Feb 18, 2021

Conversation

bradzacher
Copy link
Contributor

@bradzacher bradzacher commented Jan 29, 2021

Fixes #455

This PR is based on top of #458, and should only be merged after that one.
If you wanted to just merge one PR, then the two commits are separated appropriately.

...and fix a few lint errors

The latest version of ESLint RuleTester has a hard requirement that all fixable rules declare `meta.fixable`.
I was going to work on an issue, but this was blocking all tests after doing a fresh npm install.
@gajus gajus merged commit 04b9637 into gajus:master Feb 18, 2021
@gajus
Copy link
Owner

gajus commented Feb 18, 2021

🎉 This PR is included in version 5.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gajus gajus added the released label Feb 18, 2021
This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flowtype/sort-keys throws TypeError when handling interface types with method signatures with return types
2 participants