Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enforceLineBreak now handles export type correctly #488

Merged
merged 3 commits into from
Jul 26, 2021
Merged

enforceLineBreak now handles export type correctly #488

merged 3 commits into from
Jul 26, 2021

Conversation

Brianzchen
Copy link
Contributor

Closes #487

@Brianzchen
Copy link
Contributor Author

cc: @gajus @angelica-bocanegra

@Brianzchen
Copy link
Contributor Author

Found that node.leadingComments won't work when published, for some reason the test suite still populates the values. And eslint docs recommend sourceCode.getCommentsBefore() instead which still lead to reliable tests and now also replicates the real world

https://eslint.org/docs/user-guide/migrating-to-4.0.0#ast-nodes-no-longer-have-comment-properties

angelica-bocanegra
angelica-bocanegra approved these changes Jul 25, 2021
View reviewed changes
Copy link
Contributor

@angelica-bocanegra angelica-bocanegra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gajus gajus merged commit c40937a into gajus:master Jul 26, 2021
@gajus
Copy link
Owner

gajus commented Jul 26, 2021

🎉 This PR is included in version 5.8.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gajus gajus added the released label Jul 26, 2021
@Brianzchen Brianzchen deleted the export-type-fixer branch July 26, 2021 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angelica-bocanegra angelica-bocanegra angelica-bocanegra approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

enforce-line-break: issues with auto fixer and export type
3 participants
@Brianzchen @gajus @angelica-bocanegra