fix: handle unhandled rejection when cannot connect to proxy (fixes #1)

gajus · Jun 21, 2019 · 02086d9 · 02086d9
1 parent 307cab6
commit 02086d9
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/src/classes/Agent.js b/src/classes/Agent.js
@@ -1,6 +1,7 @@
 // @flow
 
 import EventEmitter from 'events';
+import serializeError from 'serialize-error';
 import Logger from '../Logger';
 import type {
   AgentType,
@@ -111,6 +112,12 @@ class Agent {
       if (error) {
         request.emit('error', error);
       } else {
+        socket.on('error', (socketError) => {
+          log.error({
+            error: serializeError(socketError)
+          }, 'socket error');
+        });
+
         request.onSocket(socket);
       }
     });

diff --git a/test/global-agent/routines/bootstrap.js b/test/global-agent/routines/bootstrap.js
@@ -178,6 +178,16 @@ test('proxies HTTPS request', async (t) => {
   t.assert(response.body === 'OK');
 });
 
+test('does not produce unhandled rejection when cannot connect to proxy', async (t) => {
+  bootstrap({});
+
+  const port = await getNextPort();
+
+  global.GLOBAL_AGENT.HTTP_PROXY = 'http://127.0.0.1:' + port;
+
+  await t.throwsAsync(got('http://127.0.0.1'));
+});
+
 test('proxies HTTPS request with dedicated proxy', async (t) => {
   bootstrap({});