Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React-router-redux selector documentation issue #53

Closed
callumsteele4 opened this issue Jan 13, 2017 · 3 comments
Closed

React-router-redux selector documentation issue #53

callumsteele4 opened this issue Jan 13, 2017 · 3 comments
Labels

Comments

@callumsteele4
Copy link

I was having trouble implementing redux-immutable with react-router-redux using the selector described in the README.md.

I would receive the following error:

Uncaught TypeError: Cannot read property 'charAt' of undefined
    at matchRoutes

I believe this is because the example is only converting the routing state shallowly, and can be fixed by using:

return state.get('routing').toJS()

instead of:

return state.get('routing').toObject()
@gajus gajus added the question label Jan 13, 2017
@gajus
Copy link
Owner

gajus commented Jan 13, 2017

@callumsteele4 can you confirm that toJS works?

@callumsteele4
Copy link
Author

callumsteele4 commented Jan 13, 2017

Its working for me with this change.

@gajus gajus closed this as completed in 4cc8108 Jan 13, 2017
@gajus
Copy link
Owner

gajus commented Jan 13, 2017

Thank you, @callumsteele4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants