Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please offer a browser built version #68

Closed
lovetingyuan opened this issue Aug 14, 2017 · 6 comments
Closed

please offer a browser built version #68

lovetingyuan opened this issue Aug 14, 2017 · 6 comments
Labels

Comments

@lovetingyuan
Copy link

lovetingyuan commented Aug 14, 2017

you should include a browser built file in your dist directory with an umd format, thanks

@gajus gajus added the wontfix label Aug 14, 2017
@gajus
Copy link
Owner

gajus commented Aug 14, 2017

I don't see a good reason to do that.

@gajus gajus closed this as completed Aug 14, 2017
@lovetingyuan
Copy link
Author

it is a convention,because the lib is not only used for ssr but also for browsers
most popular libs usually offer an umd build version even an es one
now, your lib can not run without building tools(webpack, browserify...), thanks

@easingthemes
Copy link

easingthemes commented May 8, 2018

Some of the reasons:

  1. Fast demo setup
  2. Create and share examples in jsfiddle/codepen.
  3. Create app without build tools
  4. Play with it in browser console

I've rebuilt the whole react/redux/thunk/reselect/immutablejs .... app in one file, and this was the only library not available trough cdn.

I can open PR, if you change your mind.
Thanks

@gajus
Copy link
Owner

gajus commented May 8, 2018

Just 👍 the issue. If there is enough demand, I will do it.

So far you are the only two people to voice the requirement in 2 years this library existed.

@vsnikkil
Copy link

@gajus this is essential for old development environments (e.g., when using requirejs). I can do PR if I have time to finalize my rollup configuration

@gajus
Copy link
Owner

gajus commented Aug 14, 2018

@gajus this is essential for old development environments (e.g., when using requirejs). I can do PR if I have time to finalize my rollup configuration

Sorry, no plan to support it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants