Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SqlTaggedTemplateType missing join #109

Closed
bradenhs opened this issue Oct 7, 2019 · 2 comments
Closed

SqlTaggedTemplateType missing join #109

bradenhs opened this issue Oct 7, 2019 · 2 comments
Labels
enhancement

Comments

@bradenhs
Copy link

bradenhs commented Oct 7, 2019

It appears SqlTaggedTemplateType in src/types.js is missing the new join method. I think whoever does the TypeScript types pretty much just bases it off of that file so the TS types on DefinitelyTyped are missing join as well.
@bradenhs bradenhs changed the title SqlTaggedTemplateType missing join SqlTaggedTemplateType missing join Oct 7, 2019
@gajus gajus closed this as completed in 28a0490 Oct 8, 2019
@gajus
Copy link
Owner

gajus commented Oct 8, 2019

🎉 This issue has been resolved in version 19.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gajus gajus added the released label Oct 8, 2019
@bradenhs
Copy link
Author

bradenhs commented Oct 8, 2019

Thanks! Great work on Slonik. It is easily my favorite postgresql client for node.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gajus @bradenhs