Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support vertical alignment #174

Merged
merged 3 commits into from
May 7, 2021
Merged

Conversation

nam-hle
Copy link
Collaborator

@nam-hle nam-hle commented May 5, 2021

  • Test
  • Docs

I'm trying to make a non-breaking change. Or should we just need to release a major. I dont know :(

@nam-hle nam-hle linked an issue May 5, 2021 that may be closed by this pull request
@coveralls
Copy link

coveralls commented May 5, 2021

Pull Request Test Coverage Report for Build 368

  • 13 of 13 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 365: 0.0%
Covered Lines: 427
Relevant Lines: 427

💛 - Coveralls

@gajus
Copy link
Owner

gajus commented May 5, 2021

I'm trying to make a non-breaking change. Or should we just need to release a major. I dont know :(

I am not opposed to breaking changes.

Just in case, this is how breaking changes need to be released:

https://github.com/semantic-release/semantic-release#commit-message-format

@nam-hle nam-hle marked this pull request as ready for review May 7, 2021 00:37
@nam-hle nam-hle changed the title feat: Support vertical alignment feat: support vertical alignment May 7, 2021
@nam-hle nam-hle merged commit d652f5c into gajus:master May 7, 2021
@nam-hle nam-hle deleted the vertical_align branch May 7, 2021 01:53
@gajus
Copy link
Owner

gajus commented May 7, 2021

🎉 This PR is included in version 6.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support alignment vertically
3 participants