Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add a Dockerfile to provide this as a docker image.
This will probably need some extra from your end if you want to publish this to Dockerhub as then an addition could be made to the README.md.
Final Docker Image size:
179MB - 175MB of that is node:16-slim
Reasons for specific things in the Dockerfile:
A comparison with the size of node_modules from npm ci vs npm install --production:
Can check with
docker run -it --entrypoint=/bin/bash waitehr:ci
if you build with making the changes to the Dockerfile to use the different commandstini
and what for?This is for proper handling of signals. Without tini the yargs command doesnt terminate correctly. I think it would be possible to have proper handling of signals but might be a more significant code change.
With
tini
the listening for SIGINT works as expected.