Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer to Peer Code Review #6

Open
trace-kadenyi opened this issue Jul 12, 2022 · 0 comments
Open

Peer to Peer Code Review #6

trace-kadenyi opened this issue Jul 12, 2022 · 0 comments

Comments

@trace-kadenyi
Copy link

Highlights

  • No linters errors.
  • Highly functional project: the todo list can add, remove, and complete tasks flawlessly among other functions.
  • I especially appreciate how you included the reload functionality to set the state back to default despite it not being in the project requirements.
  • The data is saved to local storage as required.
  • In general, the project is simple, and well-designed.
  • Best JavaScript, HTML and CSS practices are followed.

Areas of Improvement

  • Kindly capitalize the first letter of your commits as this constitutes a best practice.
  • Please include a functionality that retains the checked status of your tasks on refresh. This will improve the quality of your project and enhance the UX.
  • Some of your functions do not meet ES6 standards. Kindly use arrow functions instead as this enhances the quality of your code.
 static reloadPage() {
    const tasksList = LocalStorage.getData();
    tasksList.forEach((task) => {
      task.completed = false;
    });
    LocalStorage.saveData(tasksList);
  }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant