Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

リファクタリング #2

Open
gaku3601 opened this issue Jun 6, 2019 · 2 comments
Open

リファクタリング #2

gaku3601 opened this issue Jun 6, 2019 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@gaku3601
Copy link
Owner

gaku3601 commented Jun 6, 2019

src/FileOperation.ts
→usecase層へ
src/Migration.ts
→controller層へ

役割を明確化するためのリファクタリングを実施する。

@gaku3601 gaku3601 added the enhancement New feature or request label Jun 6, 2019
@gaku3601 gaku3601 self-assigned this Jun 6, 2019
@gaku3601
Copy link
Owner Author

gaku3601 commented Jun 7, 2019

branch[2]で実装中
[メモ]
controller層でmigrationを定義したが、usecaseに移動させる。
controllerにはcreateFileとmigrationの実行のみ記述する方向で実装予定。

@gaku3601
Copy link
Owner Author

FileOperationをusecaseへ移動。
@/usecase/migration内に意味が同じとも取れる「migration.ts」と「Index.ts」が混在している。
意図が読みにくいため、リファクタリングにおいてどうにか対応する。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant