Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix primitive e2e error #2007

Merged
merged 2 commits into from
Feb 22, 2024
Merged

Conversation

luzhuang
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:

@GuoLei1990 GuoLei1990 added the test unit test label Feb 22, 2024
@GuoLei1990 GuoLei1990 merged commit 220f9a7 into galacean:dev/1.2 Feb 22, 2024
6 checks passed
GuoLei1990 added a commit to GuoLei1990/galacean-engine that referenced this pull request Feb 26, 2024
* dev/1.2: (29 commits)
  Add `Preprocessor` in `ShaderLab` (galacean#2009)
  "v1.2.0-alpha.11"
  Add ShaderLab package umd entry (galacean#2006)
  Fix primitive e2e error (galacean#2007)
  "v1.2.0-alpha.10"
  "v1.1.0-beta.49"
  "v1.1.0-beta.48"
  Physics raycast hitResult add shape (galacean#2004)
  Fix output glsl error when `function overload` exists in shaderlab source code (galacean#2001)
  refactor: adapter shadowFadeBorder exported from editor (galacean#1999)
  refactor(render-sort-compare): opt compare code (galacean#2002)
  feat: modify the method of generating the path (galacean#2000)
  "v1.1.0-beta.47"
  Fix`gl.MIN` and `gl.MAX` doesn't exist in `webgl1` (galacean#1990)
  Fix glb/gltf use extension parse (galacean#1992)
  "v1.1.0-beta.46"
  Fix query path error (galacean#1986)
  "v1.1.0-beta.45"
  "v1.1.0-beta.44"
  Fix the problem of resetting `HtmlCanvas.ClientXXX` when call `canvas.resizeByClientSize()` (galacean#1984)
  ...
@GuoLei1990 GuoLei1990 added the ignore for release ignore for release label Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore for release ignore for release test unit test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants