Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: liquidity mining warehouse #460

Closed
wants to merge 9 commits into from

Conversation

martinfridrich
Copy link
Contributor

@martinfridrich martinfridrich commented May 24, 2022

Improve liquidity mining pallet reusability.
Common liquidity mining functionality was extracted to warehouse repository.
Reason for refactoring of this pallet is that common functionality can be used to implement liquidity mining for hydra-dx omnipool.

#446

@martinfridrich martinfridrich changed the title Feat/liquidity mining warehouse Feat: liquidity mining warehouse May 24, 2022
@martinfridrich martinfridrich changed the title Feat: liquidity mining warehouse feat: liquidity mining warehouse May 24, 2022
@martinfridrich
Copy link
Contributor Author

This PR should be reviewed and merged first: galacticcouncil/warehouse#50

@github-actions
Copy link

github-actions bot commented May 25, 2022

Crate versions that have been updated:

  • pallet-liquidity-mining: v1.2.0 -> v1.3.0
  • pallet-liquidity-mining-benchmarking: v1.0.1 -> v1.1.0
  • basilisk-runtime: v46.0.0 -> v47.0.0
  • common-runtime: v1.7.2 -> v1.9.0
  • testing-basilisk-runtime: v46.0.0 -> v47.0.0

Runtime version has been increased.

@codecov
Copy link

codecov bot commented May 25, 2022

Codecov Report

Merging #460 (aae1fb6) into master (a2e1352) will decrease coverage by 0.97%.
The diff coverage is 81.96%.

@@            Coverage Diff             @@
##           master     #460      +/-   ##
==========================================
- Coverage   83.39%   82.42%   -0.98%     
==========================================
  Files          24       24              
  Lines        2885     2515     -370     
==========================================
- Hits         2406     2073     -333     
+ Misses        479      442      -37     
Impacted Files Coverage Δ
pallets/liquidity-mining/src/migration.rs 100.00% <ø> (ø)
pallets/liquidity-mining/src/lib.rs 77.86% <77.01%> (-6.57%) ⬇️
pallets/liquidity-mining/benchmarking/src/lib.rs 92.07% <94.28%> (-1.99%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2e1352...aae1fb6. Read the comment docs.

@apopiak
Copy link
Collaborator

apopiak commented May 28, 2022

Could you update the description with what was changed and why? You just refer to the complete spec.
What are things to pay attention to? Where are you unsure/have questions?

@martinfridrich
Copy link
Contributor Author

Could you update the description with what was changed and why? You just refer to the complete spec. What are things to pay attention to? Where are you unsure/have questions?

I updated the description. Please check if I didn't introduce new bugs or see any problems, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants