-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for setting GALAXY_INSTALL_PREBUILT_CLIENT
#207
Comments
Is this being worked on? If not, I would be happy to open a PR. The ability to support the prebuilt client is crucial for us as we are aiming to do cloud deployments of galaxy, and building is slowing down deployment unacceptably long. Optionally using the prebuilt client in ansible would be a great solution! In fact, I've modified the - name: Install prebuilt client via with yarn
yarn:
executable: "yarn --network-timeout 300000 --check-files"
path: "{{ galaxy_server_dir }}"
environment:
PATH: "{{ galaxy_venv_dir }}/bin:{{ ansible_env.PATH }}"
VIRTUAL_ENV: "{{ galaxy_venv_dir }}"
when: not __galaxy_from_git.stat.exists or (__galaxy_client_build_version != __galaxy_current_commit_id)
- name: Stage prebuilt client
command: "yarn run stage"
args:
chdir: "{{ galaxy_server_dir }}"
environment:
PATH: "{{ galaxy_server_dir }}/client/node_modules/.bin:{{ galaxy_venv_dir }}/bin:{{ ansible_env.PATH }}"
VIRTUAL_ENV: "{{ galaxy_venv_dir }}"
when: "__galaxy_major_version is version('23.0', '>=')" I noticed that the |
Thanks! A PR would definitely be welcome. The make-based build process currently updates - name: Write client_build_hash.txt
copy:
content: "{{ __galaxy_current_commit_id }}"
dest: "{{ galaxy_static_dir }}/client_build_hash.txt"
mode: "0644" |
Thanks for the suggestion! Or maybe it makes sense to just skip the entire comparison between commit hashes in case |
Yes, that would be even better. To fit with existing naming maybe |
Since we're not using
run.sh
, we'll need to re-implement it, but it would be really nice to have support for this variable. I don't think there's many (any?) other run.sh variables we really want to make configurable but this is definitely one.The text was updated successfully, but these errors were encountered: