Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ROM header parsing from mem to rom #53

Closed
mzal opened this issue Aug 26, 2020 · 0 comments · Fixed by #59
Closed

Move ROM header parsing from mem to rom #53

mzal opened this issue Aug 26, 2020 · 0 comments · Fixed by #59
Assignees
@mzal
Labels
enhancement New feature or request
Projects
GBC Emu

Comments

@mzal
Copy link
Collaborator

mzal commented Aug 26, 2020

I would think that rom module might be the right place to have this sort of thing. Though, I think we could do a bigger refactor and move all of the ROM-header parsing logic and make g_mem_cart_type accessible to other modules. We can make it a separate issue.

Originally posted by @mzal in #50 (comment)
@mzal mzal self-assigned this Aug 29, 2020
@mzal mzal linked a pull request Sep 2, 2020 that will close this issue
Move header parsing logic to rom module (#53) #59
Merged
@mzal mzal added the enhancement New feature or request label Sep 2, 2020
@mzal mzal added this to Project Backlog in GBC Emu via automation Sep 2, 2020
mzal pushed a commit that referenced this issue Sep 3, 2020
move ROM header parsing logic to rom module (closes #53)
846e610 
* add rom_is_cgb to rom API
* use rom_is_cgb in gpu.c
* move GBC mode with uninitialized palettes parsing to rom.c
* add void to empty arguments lists in gpu
* ints.c is not executable
@mzal mzal closed this as completed in #59 Sep 3, 2020
GBC Emu automation moved this from Project Backlog to Done Sep 3, 2020
mzal added a commit that referenced this issue Sep 3, 2020
@mzal
move ROM header parsing logic to rom module (closes #53) (#59)
8c6f47c 
* add rom_is_cgb to rom API
* use rom_is_cgb in gpu.c
* move GBC mode with uninitialized palettes parsing to rom.c
* add void to empty arguments lists in gpu
* ints.c is not executable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mzal mzal

Labels
enhancement New feature or request
Projects
GBC Emu
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move header parsing logic to rom module (#53) galeblon/GBC_Emulator
1 participant
@mzal