New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4.2.0 Breaking Change - Extract dimensions #670
Comments
Hm, I'm already did it. |
Please note that this was a breaking API change which didn't follow semver. I suggest aliasing the method and bumping the version as a bugfix release. Cheers - Victor |
Awesome, I have been running into a problem with config Here is my uploader. The verison of CKeditor is 4.2.2 # encoding: utf-8
class CkeditorPictureUploader < CarrierWave::Uploader::Base
include Ckeditor::Backend::CarrierWave
include CarrierWave::MiniMagick
include Cloudinary::CarrierWave
process :extract_dimensions
[:extract_content_type, :extract_size, :extract_dimensions].each do |method|
define_method :"#{method}_with_cloudinary" do
send :"#{method}_without_cloudinary" if self.file.is_a? CarrierWave::SanitizedFile
{}
end
alias_method_chain method, :cloudinary
end
version :thumb do
process :resize_to_fill => [118, 100]
end
version :content do
process :resize_to_limit => [800, 800]
end
def extension_white_list
Ckeditor.image_file_types
end
end |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For those who are getting the following message:
Your generated uploader needs to be updated;
Change line 31 from
read_dimensions
toextract_dimensions
For reference this is the breaking change
The text was updated successfully, but these errors were encountered: