Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP and Galette versions as ARG for dockerfile #21

Closed
grasdk opened this issue Apr 25, 2024 · 2 comments
Closed

PHP and Galette versions as ARG for dockerfile #21

grasdk opened this issue Apr 25, 2024 · 2 comments

Comments

@grasdk
Copy link
Collaborator

grasdk commented Apr 25, 2024

Rather than continously releasing a new Dockerfile with each Galette Release, let the version numbers be ARGs

PHP can have a default varsion if not provided (i.e. 8.2)
Galette verison would be required as input for the docker build command.

When doing a new release to trigger the build and publish action, the version of Galette could be extracted from the release TAG.

Some beginning references:

@grasdk
Copy link
Collaborator Author

grasdk commented May 26, 2024

PR soon ready to be merged. Waiting for next release.

Have been building two RC using command line args:

galette-1.1.0-rc1-20240508-95bbbc2ede

 docker buildx build --platform linux/amd64 -t galette-local-prerelease \
    --build-arg MAIN_PACKAGE_URL=https://galette.eu/download/dev/ \
    --build-arg GALETTE_RELEASE=galette-1.1.0-rc1-20240508-95bbbc2ede \
    --build-arg PLUGIN_AUTO_VERSION=dev \
    --build-arg PLUGIN_EVENTS_VERSION=dev \
    --build-arg PLUGIN_FULLCARD_VERSION=dev \
    --build-arg PLUGIN_MAPS_VERSION=dev \
    --build-arg PLUGIN_OBJECTSLEND_VERSION=dev \
    --build-arg PLUGIN_PAYPAL_VERSION=dev \
    --load .

galette-1.1.0-rc2-20240518-ed53328d5d:

docker buildx build --platform linux/amd64 -t galette-local-prerelease \
--build-arg MAIN_PACKAGE_URL=https://galette.eu/download/dev/ \
--build-arg GALETTE_RELEASE=galette-1.1.0-rc2-20240518-ed53328d5d \
--build-arg PLUGIN_AUTO_VERSION=dev \
--build-arg PLUGIN_EVENTS_VERSION=dev \
--build-arg PLUGIN_FULLCARD_VERSION=dev \
--build-arg PLUGIN_MAPS_VERSION=dev \
--build-arg PLUGIN_OBJECTSLEND_VERSION=dev \
--build-arg PLUGIN_PAYPAL_VERSION=dev \
--load .

@grasdk
Copy link
Collaborator Author

grasdk commented Jun 15, 2024

@grasdk grasdk closed this as completed Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant