Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverage fails with wrong number of lines #11 #25

Open
rohitri-90 opened this issue Sep 10, 2018 · 2 comments
Open

Coverage fails with wrong number of lines #11 #25

rohitri-90 opened this issue Sep 10, 2018 · 2 comments

Comments

@rohitri-90
Copy link

Hi
We are facing the issue of sonar coverage failing with wrong line number which is similar to the issue fixed in #11 with the recent upgrade of the plugin to version 2.0 the changes are missing which fixed the issue.

ERROR: Error during Sonar runner execution
ERROR: Unable to execute Sonar
ERROR: Caused by: Line 39 is out of range in the file cbc-mimir-np-inventory/src/main/java/com/services/business/config/FeignClientConfiguration.java (lines: 30)
ERROR:

We think sonar analysis should not fail in case of code coverage even if there are some mismatch of line numbers for some file.

Regards
Rohit

@rohitri-90
Copy link
Author

Hi Geoffrey
I have already fixed the issue in #11
and have again done the fix for the latest plugin version(2.0).Please let me know if you are going to merge the same code from old PR or shall i submit a new PR for the same and please also let me know which branch shall i submit the pull request .

Regards
Rohit

@galexandre
Copy link
Owner

Hi @rohitri-90,

Sorry for the delay of my answer.
I will have a look at the PR you have opened and apply the changes.

Regards,

Geoffrey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants