Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.1.0 #36

Closed
noklam opened this issue Sep 1, 2023 · 7 comments
Closed

Release v0.1.0 #36

noklam opened this issue Sep 1, 2023 · 7 comments
Assignees

Comments

@noklam
Copy link
Collaborator

noklam commented Sep 1, 2023

Description

Context

Possible Implementation

Possible Alternatives

@noklam noklam self-assigned this Sep 1, 2023
@noklam
Copy link
Collaborator Author

noklam commented Sep 1, 2023

@Galileo-Galilei I am not familiar with the release workflow, I saw there is a prepare-release workflow and seems like it bump version automatically. How does the release process work?

@Galileo-Galilei
Copy link
Owner

Galileo-Galilei commented Sep 1, 2023

The release workflow works in 2-steps:

  • the create-release-candidate worklow which bumps the changelog and the version and opens a PR to enable manuel fixes at this step (eg. if the release notes are not up to date)

  • Once the PR is merged, the publish worklow creates a github release and deploy the main branch to PyPI

@Galileo-Galilei
Copy link
Owner

Galileo-Galilei commented Sep 1, 2023

I'll do it tonight, for some unknown reason I cant trigger the workflow through the Android app.

@noklam
Copy link
Collaborator Author

noklam commented Sep 1, 2023

@Galileo-Galilei I fixed a bug in the Github action but run into permission error. Maybe it has to be you running the workflow. https://github.com/Galileo-Galilei/kedro-pandera/actions/runs/6052281404/job/16425421416

@Galileo-Galilei
Copy link
Owner

Galileo-Galilei commented Sep 1, 2023

I'll check this. I may have not enable / configured my PyPI and github tokens for this repo when I created it at first. I'll wait you to merge #32 before I trigger the release.

Do you think that it is appropriate to make an announcement on the kedro slack to attract users or is this considered as too aggressive self promotion and reserved to the team for "official" products?

@noklam
Copy link
Collaborator Author

noklam commented Sep 1, 2023

I think it's fine to do it on #plugin-integration channels, but probably better to announce by you to avoid people thinking this is from the official Kedro team.

@Galileo-Galilei
Copy link
Owner

Done!

I close the issue but we may need to refactor the github action & advertise on the slack channel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants