Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fatal errors while testing galio #67

Closed
ghost opened this issue Jan 15, 2019 · 19 comments
Closed

Fatal errors while testing galio #67

ghost opened this issue Jan 15, 2019 · 19 comments
Labels
help wanted Extra attention is needed Type: Bug Something isn't working

Comments

@ghost
Copy link

ghost commented Jan 15, 2019

Describe the bug
Hi. I'm having a problem while trying to use Galio. With a fresh expo app I get the following error: undefined is not an object (evaluating 'Constants.manifest') if I'm connected via tunnel or local.

If I'm connected via LAN i get the following error: Uncaught Error: 23.0.0 is not a valid SDK version.

To Reproduce
1- expo init
2- yarn add galio-framework
2-

// App.js
import React from 'react';
import { StyleSheet, Text, View } from 'react-native';
import { Button } from 'galio-framework';

export default class App extends React.Component {
  render() {
    return (
      <View style={styles.container}>
        <Text>Open up App.js to start working on your app!</Text>
        <Button>Press here!</Button>
      </View>
    );
  }
}

const styles = StyleSheet.create({
  container: {
    flex: 1,
    backgroundColor: '#fff',
    alignItems: 'center',
    justifyContent: 'center',
  },
});

Screenshots
screenshot_2019-01-14-22-48-08
screenshot_2019-01-14-23-01-40

Smartphone (please complete the following information):

  • Device: TPLINK TP701A
  • Type of device: physical
  • OS: Android 5.1
  • React-Native version: 32
  • Expo version: 32

Computer (please complete the following information):

  • OS: Ubuntu Linux 18.10
  • Node version: 10.12.0
  • Expo CLI version: 2.6.14
@hetmann
Copy link
Collaborator

hetmann commented Jan 15, 2019

@fbraz can you copy/paste the View error log details?
Also can you try to update the Expo App to the latest version if it isn't up-to-date?

@palingheorghe palingheorghe added the Type: Bug Something isn't working label Jan 15, 2019
@ghost
Copy link
Author

ghost commented Jan 15, 2019

Sorry, it doesn't give details. The View error log is as described and it doesn't show on my terminal. I had to install GSConnect to paste the clipboard from my phone and is the same as above:

undefined is not an object (evaluating 'Constants.manifest')
<unknown>
    Asset.js:28:35
loadModuleImplementation
    require.js:292:12
<unknown>
    Expo.js:282:7
loadModuleImplementation
    require.js:292:12
<unknown>
    Icon.js:2
loadModuleImplementation
    require.js:292:12
<unknown>
    index.js:4
loadModuleImplementation
    require.js:292:12
<unknown>
    App.js:7
loadModuleImplementation
    require.js:292:12
<unknown>
    AppEntry.js:2
loadModuleImplementation
    require.js:292:12
guardedLoadModule
    require.js:179:45
global code

Sorry but the errors messages that expo gives are not easy to understand.

On the other hand, my connection error via LAN was due to being connected via a VPN provider wich blocked LAN connections and I wasn't aware of that.

Expo client app version is 2.10.3. It was updated yesterday before trying Galio.

@hetmann
Copy link
Collaborator

hetmann commented Jan 16, 2019

Galio uses Expo SDK version 29.0.0, same with react-native, you can check Galio package.json
On the other hand Expo SDK version 23.0.0 has Constants.manifest

Maybe you can try on another computer or personal one.

@palingheorghe
Copy link
Collaborator

Hi,
I've looked into this problem a bit and as far as I can see a lot of people are having this same exact issue but no real solution was found.

Take a look here: issue #184 of react-native-video repo. This is not the exact same error but it's a good place to start in order to find a good solution.

I agree with @hetmann you should try using Galio on another computer and see how it behaves. I also encountered a similar error once but after updating Expo and creating a fresh new project, Galio worked and no more issues were ecountered.

Keep us updated!

❤️

@ghost
Copy link
Author

ghost commented Jan 16, 2019

Galio uses Expo SDK version 29.0.0, same with react-native, you can check Galio package.json

I know, I'm using v29 too. Ok, I will try on another computer. Thank you both

@rteobaldo
Copy link

There is some update about that? I'm having the same bug.

@ghost
Copy link
Author

ghost commented Jan 30, 2019

Ok, so it's not my machine. What are your specs @rteobaldo? Are you on linux?

P.S: I tried on another computer but had the exact same problem. I forgot to update this thread about that, although my other pc has the same operating system (Ubuntu 18.10), nvm and node versions.

@palingheorghe
Copy link
Collaborator

Hi @rteobaldo @fbraz,
I'm going to make some more tests and figure out what the problem is. Meanwhile, any new information regarding this would be of much help to me.

Thank you very much,
❤️

@ethan-hurst
Copy link

ethan-hurst commented Feb 7, 2019

I'm also getting this exact same error.

Initiated a brand new expo app using the expo CLI.

Dependancy versions

    "expo": "^32.0.0",
    "galio-framework": "^0.4.2",
    "react": "16.5.0",
    "react-native": "https://github.com/expo/react-native/archive/sdk-32.0.0.tar.gz"
  }

Then on an attempt to view this framework in the expo app, I'm getting the exact same error as listed above.

This is my OS version

image

yarn 1.13
node v10.13.0
npm 6.4.1
expo 2.9.0


<unknown>
    AppEntry.bundle?platform=ios&dev=true&minify=false&hot=false&assetPlugin=C%3A%5CUsers%5CEthan%5CGitHub%5CGalio-Test%5Cnode_modules%5Cexpo%5Ctools%5ChashAssetFiles.js:157348:35
loadModuleImplementation
    AppEntry.bundle?platform=ios&dev=true&minify=false&hot=false&assetPlugin=C%3A%5CUsers%5CEthan%5CGitHub%5CGalio-Test%5Cnode_modules%5Cexpo%5Ctools%5ChashAssetFiles.js:262:14
<unknown>
    AppEntry.bundle?platform=ios&dev=true&minify=false&hot=false&assetPlugin=C%3A%5CUsers%5CEthan%5CGitHub%5CGalio-Test%5Cnode_modules%5Cexpo%5Ctools%5ChashAssetFiles.js:151920:14
loadModuleImplementation
    AppEntry.bundle?platform=ios&dev=true&minify=false&hot=false&assetPlugin=C%3A%5CUsers%5CEthan%5CGitHub%5CGalio-Test%5Cnode_modules%5Cexpo%5Ctools%5ChashAssetFiles.js:262:14
<unknown>
    AppEntry.bundle?platform=ios&dev=true&minify=false&hot=false&assetPlugin=C%3A%5CUsers%5CEthan%5CGitHub%5CGalio-Test%5Cnode_modules%5Cexpo%5Ctools%5ChashAssetFiles.js:151502:26
loadModuleImplementation
    AppEntry.bundle?platform=ios&dev=true&minify=false&hot=false&assetPlugin=C%3A%5CUsers%5CEthan%5CGitHub%5CGalio-Test%5Cnode_modules%5Cexpo%5Ctools%5ChashAssetFiles.js:262:14
<unknown>
    AppEntry.bundle?platform=ios&dev=true&minify=false&hot=false&assetPlugin=C%3A%5CUsers%5CEthan%5CGitHub%5CGalio-Test%5Cnode_modules%5Cexpo%5Ctools%5ChashAssetFiles.js:150396:49
loadModuleImplementation
    AppEntry.bundle?platform=ios&dev=true&minify=false&hot=false&assetPlugin=C%3A%5CUsers%5CEthan%5CGitHub%5CGalio-Test%5Cnode_modules%5Cexpo%5Ctools%5ChashAssetFiles.js:262:14
<unknown>
    AppEntry.bundle?platform=ios&dev=true&minify=false&hot=false&assetPlugin=C%3A%5CUsers%5CEthan%5CGitHub%5CGalio-Test%5Cnode_modules%5Cexpo%5Ctools%5ChashAssetFiles.js:150259:36
loadModuleImplementation
    AppEntry.bundle?platform=ios&dev=true&minify=false&hot=false&assetPlugin=C%3A%5CUsers%5CEthan%5CGitHub%5CGalio-Test%5Cnode_modules%5Cexpo%5Ctools%5ChashAssetFiles.js:262:14
<unknown>
    AppEntry.bundle?platform=ios&dev=true&minify=false&hot=false&assetPlugin=C%3A%5CUsers%5CEthan%5CGitHub%5CGalio-Test%5Cnode_modules%5Cexpo%5Ctools%5ChashAssetFiles.js:1803:48
loadModuleImplementation
    AppEntry.bundle?platform=ios&dev=true&minify=false&hot=false&assetPlugin=C%3A%5CUsers%5CEthan%5CGitHub%5CGalio-Test%5Cnode_modules%5Cexpo%5Ctools%5ChashAssetFiles.js:262:14
guardedLoadModule
    AppEntry.bundle?platform=ios&dev=true&minify=false&hot=false&assetPlugin=C%3A%5CUsers%5CEthan%5CGitHub%5CGalio-Test%5Cnode_modules%5Cexpo%5Ctools%5ChashAssetFiles.js:150:47
global code
    AppEntry.bundle?platform=ios&dev=true&minify=false&hot=false&assetPlugin=C%3A%5CUsers%5CEthan%5CGitHub%5CGalio-Test%5Cnode_modules%5Cexpo%5Ctools%5ChashAssetFiles.js:190011:4

@idrakimuhamad
Copy link

Getting the same error too on freshly created app.

"expo": "^32.0.0",
"react": "16.5.0",
"react-native": "https://github.com/expo/react-native/archive/sdk-32.0.0.tar.gz",
"galio-framework": "^0.4.2",

The error seems to be originated from expo-asset which look up on expo-constants. Both this packages seems present in the node_modules.

@palingheorghe
Copy link
Collaborator

Hi @idrakimuhamad, @Flamebeard ! I wasn't able to fix this issue at the moment so I'm going to have to keep on trying. I am getting the exact same error while using yarn. Another type of error pops up while using npm.

Small summary with the current status of this situation:

  • npm error: As far as I could get I noticed that a different type of error pops up because of react-native-svg
  • yarn error: Different kind of error ('Constants.manifest'). @idrakimuhamad said something about the error being originated from expo-asset and expo-constants.

I'll keep on lookin' into this, any help you could give me regarding this is appreciated. I'll come back with updates!

Thanks!

@palingheorghe palingheorghe added the help wanted Extra attention is needed label Feb 8, 2019
@palingheorghe
Copy link
Collaborator

Easy and fast fix:
Until I'll be able to solve the issues (which are clearly regarding node_modules) you can always continue creating your apps with Galio.

The easiest and best way to still use Galio with your app is the following:

Clone our repo in a different folder. Go ahead and copy the insides of the src folder and create a new folder in your project's root folder (you could call it galio, that's what I did 🧜🏽‍♂️). You can now still use the components like this: import { Button } from './galio'

Hope this helps your for now. I hope I'll solve this bug as fast as possible. I'm going to tag you guys in order to make sure you see this: @idrakimuhamad, @Flamebeard, @fbraz, @rteobaldo !

Thanks for your patience! ❤️

@ethan-hurst
Copy link

ethan-hurst commented Feb 10, 2019

Small summary with the current status of this situation:

  • npm error: As far as I could get I noticed that a different type of error pops up because of react-native-svg
  • yarn error: Different kind of error ('Constants.manifest'). @idrakimuhamad said something about the error being originated from expo-asset and expo-constants.

I'll keep on lookin' into this, any help you could give me regarding this is appreciated. I'll come back with updates!

Thanks for your help man, If you need help replicating this then please let me know, I'm happy to help out testing this for you if need be 😃

Clone our repo in a different folder. Go ahead and copy the insides of the src folder and create a new folder in your project's root folder (you could call it galio, that's what I did 🧜🏽‍♂️). You can now still use the components like this: import { Button } from './galio'

Can also confirm that this work around is functioning for the time being, thank you for your efforts!

@ghost
Copy link
Author

ghost commented Feb 11, 2019

The error seems to be originated from expo-asset which look up on expo-constants. Both this packages seems present in the node_modules.

@idrakimuhamad How did you get to know about that?
@palingheorghe Thank you very much!

@ethan-hurst
Copy link

@idrakimuhamad How did you get to know about that?

I wondered the same thing

@idrakimuhamad
Copy link

@fbraz @Flamebeard Well I can only assumed that based on the thrown error that it happened in the Asset.js which when I look up, happens to be in expo-asset which reading the Manifest constants from expo-contants. 😬Could totally be unrelated

@hetmann
Copy link
Collaborator

hetmann commented Feb 11, 2019

@palingheorghe Just update the expo version to the latest one :)

@palingheorghe
Copy link
Collaborator

Hi again @fbraz, @Flamebeard, @rteobaldo, @idrakimuhamad!

You should try reinstalling Galio. It is now working as expected ❤️.
Thanks @hetmann for the tip and thank you all for your patience!

Happy coding!

@idrakimuhamad
Copy link

@palingheorghe can confirm its working alright on 0.4.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants