Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some errors in the code #23

Closed
gangweiX opened this issue Oct 12, 2021 · 1 comment
Closed

Some errors in the code #23

gangweiX opened this issue Oct 12, 2021 · 1 comment

Comments

@gangweiX
Copy link

for cfnet.py, First error:
def generate_search_range(self, sample_count, input_min_disparity, input_max_disparity):
"""
Description: Generates the disparity search range.
Returns:
:min_disparity: Lower bound of disparity search range
:max_disparity: Upper bound of disaprity search range.
"""

    min_disparity = torch.clamp(input_min_disparity - torch.clamp((
            sample_count - input_max_disparity + input_min_disparity), min=0) / 2.0, min=0, max=self.maxdisp)
    max_disparity = torch.clamp(input_max_disparity + torch.clamp(
            sample_count - input_max_disparity + input_min_disparity, min=0) / 2.0, min=0, max=self.maxdisp)

    return min_disparity, max_disparity

it should be "min_disparity = torch.clamp(input_min_disparity - torch.clamp((
sample_count - input_max_disparity + input_min_disparity), min=0) / 2.0, min=0, max=self.maxdisp//4-1)
max_disparity = torch.clamp(input_max_disparity + torch.clamp(
sample_count - input_max_disparity + input_min_disparity, min=0) / 2.0, min=0, max=self.maxdisp//4-1)"
or "min_disparity = torch.clamp(input_min_disparity - torch.clamp((
sample_count - input_max_disparity + input_min_disparity), min=0) / 2.0, min=0, max=self.maxdisp//2-1)
max_disparity = torch.clamp(input_max_disparity + torch.clamp(
sample_count - input_max_disparity + input_min_disparity, min=0) / 2.0, min=0, max=self.maxdisp//2-1)"

Second error: in line 643 of cfnet.py, it should be "predmid_s2 = F.upsample(predmid_s2 * 2, [left.size()[2], left.size()[3]], mode='bilinear', align_corners=True)", not "predmid_s2 = F.upsample(predmid_s2 * 4, [left.size()[2], left.size()[3]], mode='bilinear', align_corners=True)"

@gallenszl
Copy link
Owner

Thank you very much! I have fixed the two bugs in the cfnet.py file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants