xor function raises TypeError: pop expected at least 1 argument, got 0

[marinelay]

pwntools/pwnlib/util/fiddling.py

Lines 306 to 330 in 5981c72

	# misc binary functions
	def xor(*args, **kwargs):
	"""xor(*args, cut = 'max') -> str
	Flattens its arguments using :func:`pwnlib.util.packing.flat` and
	then xors them together. If the end of a string is reached, it wraps
	around in the string.
	Arguments:
	args: The arguments to be xor'ed together.
	cut: How long a string should be returned.
	Can be either 'min'/'max'/'left'/'right' or a number.
	Returns:
	The string of the arguments xor'ed together.
	Example:
	>>> xor(b'lol', b'hello', 42)
	b'. ***'
	"""
	cut = kwargs.pop('cut', 'max')
	if kwargs != {}:
	raise TypeError("xor() got an unexpected keyword argument '%s'" % kwargs.pop()[0])

At line 330, it raises the type error TypeError: pop expected at least 1 argument, got 0 because pop method cannot be used without arguments.

I believe that it should be fixed to report proper error message.

[Arusekk]

The code looks as if the intention was always to use popitem; anyway, when we finally drop py2 support, we could finally use keyword-only arguments here to get rid of all of this boilerplate.

Have you spotted more such uses throughout the code?

[marinelay]

I couldn't find any other occurrences for dict.pop like this issue