Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HSM fails on Image constructed from flipped numpy array #1185

Closed
jmeyers314 opened this issue Oct 20, 2022 · 1 comment · Fixed by #1186
Closed

HSM fails on Image constructed from flipped numpy array #1185

jmeyers314 opened this issue Oct 20, 2022 · 1 comment · Fixed by #1186
Milestone
v2.4

Comments

@jmeyers314
Copy link
Member 

import galsim
img = galsim.Gaussian(fwhm=1).drawImage()
galsim.hsm.FindAdaptiveMom(galsim.Image(img.array[::-1]))

gives

RuntimeError: Failed Assert: newdata < _maxptr at src/Image.cpp:374

in version >= 2.4

Works in version = 2.3.
rmjarvis added a commit that referenced this issue Oct 21, 2022
@rmjarvis
Fix hsm assert when step or stride is < 0
f2b236d 
(#1185)
@rmjarvis rmjarvis linked a pull request Oct 21, 2022 that will close this issue
Fix hsm assert when step or stride is < 0 #1186
Merged
@rmjarvis
Copy link
Member

Sorry. My bad. #1186

rmjarvis added a commit that referenced this issue Oct 21, 2022
@rmjarvis
Update code comment
b9d26f9 
(#1185)
rmjarvis added a commit that referenced this issue Oct 21, 2022
@rmjarvis
Skip some timing tests on pypy
0739564 
(#1185)
rmjarvis added a commit that referenced this issue Oct 21, 2022
@rmjarvis
Fix hsm assert when step or stride is < 0
342fb1f 
(#1185)
rmjarvis added a commit that referenced this issue Oct 21, 2022
@rmjarvis
Update code comment
2af0849 
(#1185)
rmjarvis added a commit that referenced this issue Oct 21, 2022
@rmjarvis
Skip some timing tests on pypy
bb85d07 
(#1185)
rmjarvis added a commit that referenced this issue Oct 21, 2022
@rmjarvis
Fix hsm assert when step or stride is < 0
20898f2 
(#1185)
rmjarvis added a commit that referenced this issue Oct 21, 2022
@rmjarvis
Skip some timing tests on pypy
7cbbf8d 
(#1185)
@rmjarvis rmjarvis added this to the v2.4 milestone Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.4
Development

Successfully merging a pull request may close this issue.

Fix hsm assert when step or stride is < 0 GalSim-developers/GalSim
2 participants
@rmjarvis @jmeyers314