Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HEADLESS] batch facet parallel suppress headless flag -hpc #3687

Closed
RoiArthurB opened this issue Mar 28, 2023 · 0 comments
Closed

[HEADLESS] batch facet parallel suppress headless flag -hpc #3687

RoiArthurB opened this issue Mar 28, 2023 · 0 comments
Assignees
Labels
About Batch This issue concerns batch experiments About Headless This issue or request concerns GAMA headless mode 😱 Bug The issue reveals a bug in GAMA V. 1.9.0 Bug specific to 1.9.0

Comments

@RoiArthurB
Copy link
Collaborator

Describe the bug
As pointed in this issue #3658 if a batch experiment is launched in headless mode, the facet parallel: written in GAML will overwrite the headless' flag -hpc.

This is an issue as the facet could be set for development purpose but should be prioritized in headless mode if an headless attribute is set.

To Reproduce
Steps to reproduce the behavior:

  1. Create a batch experiment with the facet parallel: set to any number (e.g 2)
  2. Start the experiment in batch headless with another core limit (e.g 1) with this command:
bash gama-headless.sh -hpc 1 -batch myBatchExp ./path/to/model.gaml
  1. See experiments starting by pair of 2

Expected behavior

The expected behavior was well summarized by @AlexisDrogoul :

So we should probably work a bit on the priority of these options.

Right now, we have:

  • no -hpc, no parallel:: pref_parallel_simulations_all is considered as true and all cores are used.
  • no -hpc, parallel: defined: pref_parallel_simulations_all is considered as true but in the limit defined by parallel
  • -hpc defined, parallel: defined or not: it seems that the value of -hpc is not considered.

In my opinion, when the modeler wants to limit the number of threads, -hpc should have the priority, followed by parallel:. The easiest solution would then be to translate the value passed from -hpc to parallel: before launching the experiment. What do you think ?

Additional context
If the facet parallel: isn't used, everything is working as intended. This issue is explained in the documentation

@RoiArthurB RoiArthurB added 😱 Bug The issue reveals a bug in GAMA About Batch This issue concerns batch experiments About Headless This issue or request concerns GAMA headless mode V. 1.9.0 Bug specific to 1.9.0 labels Mar 28, 2023
@RoiArthurB RoiArthurB self-assigned this Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
About Batch This issue concerns batch experiments About Headless This issue or request concerns GAMA headless mode 😱 Bug The issue reveals a bug in GAMA V. 1.9.0 Bug specific to 1.9.0
Projects
No open projects
Status: Done
Development

No branches or pull requests

1 participant