Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEST: Migrate tests for mixed behavior profiles to pytest style #375

Closed
tturocy opened this issue Oct 6, 2023 · 0 comments · Fixed by #420
Closed

TEST: Migrate tests for mixed behavior profiles to pytest style #375

tturocy opened this issue Oct 6, 2023 · 0 comments · Fixed by #420
Assignees
Labels
python Items which involve coding in Python tests Items which involve the pygambit test suite
Milestone

Comments

@tturocy
Copy link
Member

tturocy commented Oct 6, 2023

We have something of a test suite for mixed behavior profiles (see src/pygambit/tests/test_behav.py). It is at the moment written in unittest style. Further, it is not ideal as the separate tests are not isolated (they all depend on strategy profiles which are defined at the class level).

#. Rewrite the tests to be in pytest style, with individual functions exercising specific features
#. Construct a parameterisation of the tests to consider several interesting games, and test edge cases. This requires a bit of experience with game theory to be aware of where calculations with mixed behavior profiles are likely to have problems (specifically with parts of the tree that are reached with zero probability!)

This could be considered in conjunction with #374 as well. The issues with the existing test suite are slightly different (the mixed behavior tests do consider a nontrivial game unlike the mixed strategy tests). However, more robust testing of the mapping between strategy and behavior profiles and the application of Kuhn's Theorem (and testing what happens for games without perfect recall!!!) could make it work someone attacking both issues in tandem.

@tturocy tturocy added python Items which involve coding in Python tests Items which involve the pygambit test suite labels Oct 6, 2023
@tturocy tturocy added this to the gambit-16.2.0 milestone Oct 6, 2023
@VarsosC VarsosC self-assigned this Oct 24, 2023
@rahulsavani rahulsavani self-assigned this Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Items which involve coding in Python tests Items which involve the pygambit test suite
Projects
None yet
3 participants