Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic Auth/TLS broken in marathonClient.AddEventsListener() #148

Closed
emilevauge opened this issue May 12, 2016 · 6 comments
Closed

Basic Auth/TLS broken in marathonClient.AddEventsListener() #148

emilevauge opened this issue May 12, 2016 · 6 comments
Assignees
@gambol99
Labels
bug

Comments

@emilevauge
Copy link

When we create a marathon client with basic auth and/or TLS, the call to marathonClient.AddEventsListener() returns an error:

401: <html>
<head>
<meta http-equiv="Content-Type" content="text/html;charset=ISO-8859-1"/>
<title>Error 401 </title>
</head>
<body>
<h2>HTTP ERROR: 401</h2>
<p>Problem accessing /v2/events. Reason:
<pre>    Unauthorized</pre></p>
<hr /><a href="http://eclipse.org/jetty">Powered by Jetty:// 9.3.z-SNAPSHOT</a><hr/>
</body>
</html>

with TLS:

x509: certificate is valid for *.mydomain.net, mydomain.net, not ***.***.***.***.mydomain.net

Here is the code used to register listeners: https://github.com/containous/traefik/blob/master/provider/marathon.go#L67

It seems marathonClient.AddEventsListener() doesn't use TLS/basic auth client config.
@emilevauge emilevauge mentioned this issue May 12, 2016
Closed
@gambol99 gambol99 added the bug label May 23, 2016
@gambol99 gambol99 self-assigned this May 23, 2016
@arichardet
Copy link

Any resolution on this?

@timoreimann
Copy link
Collaborator

timoreimann commented May 25, 2016 •
edited

@arichardet I suppose #142 will provide a fix for the problem once that PR has been merged.

@gambol99
Copy link
Owner

@timoreimann ... i think #142 fixes the auth but not TLS. I've raised a PR donovanhide/eventsource#22 to permit overriding the client

@timoreimann
Copy link
Collaborator

Good point, those are indeed two different issues. Thanks!

@gambol99 gambol99 mentioned this issue May 25, 2016
Closed
@gambol99 gambol99 mentioned this issue Jun 5, 2016
Merged
@gambol99
Copy link
Owner

was fixed in #156

@emilevauge
Copy link
Author

Thanks a lot @gambol99 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gambol99 gambol99

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@timoreimann @arichardet @gambol99 @emilevauge