BUG: (minor) Token ID Attributes Should Be Strings

[mccallofthewild]

Summary of Bug

Nothing crazy here. The newtype pattern's benefits do not extend to response attributes. Token ID attrs should be formatted such that transactions can be easily searched and indexed by token id.

Environment

• OS: MacOS
• Software version: cw-ics721-bridge

Steps to Reproduce

Steps to reproduce the behavior:
Transfer cw-ics721-bridge

Expected and Actual Behavior

Expected:

.add_attribute("token_id", String::from(token_id))

"value": "mytokenid"

Actual:

.add_attribute("token_id", token_id)

"value": "[TokenId(\"mytokenid\")]"

Error Stack

NA

Additional Context

NA

[mccallofthewild]

Recommendation:

Use duplicate attributes to express batch transfers. There is no practical way for BigDipper et al to index a serde vec.

Expected:

        Ok(IbcBasicResponse::new()
            // ...
            .add_attributes(
                msg.token_ids
                    .into_iter()
                    .map(|token_id| ("token_id".to_string(), String::from(token_id)))
                    .collect::<Vec<(String, String)>>(),
            ))
            // "token_id" => "mytokenid1"
            // "token_id" => "mytokenid2"

Actual:

    Ok(IbcBasicResponse::new()
        .add_messages(messages)
        .add_attribute("method", "handle_packet_fail")
        .add_attribute("token_ids", format!("{:?}", message.token_ids)) // "[TokenId(\"mytokenid1\"),TokenId(\"mytokenid2\")]"