Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async methods on objects that are array elements #257

Closed
daltones opened this issue Sep 29, 2016 · 3 comments
Closed

Async methods on objects that are array elements #257

daltones opened this issue Sep 29, 2016 · 3 comments

Comments

@daltones
Copy link
Contributor

Here's an example:
captura de tela de 2016-09-29 18-38-02

As you can see if an object is an array element, all nested objects are affected too.

We're almost there 馃槃

@gandm
Copy link
Owner

gandm commented Sep 30, 2016

Um! It was designed to work if you put the curly brace immediately after the array open. var foo = [{ but that isn't what you want. This is more tricky than you'd imagine because I've tried to be spec correct and only allow method's inside object literals. Unfortunately, flow complicates this because I have to be aware what side of the assignment operator the object definition is, as this affects the parsing. Oh for being able to maintain state in TextMate grammars!!

@gandm gandm added the bug label Sep 30, 2016
@gandm gandm closed this as completed in 4c4b968 Sep 30, 2016
@gandm
Copy link
Owner

gandm commented Sep 30, 2016

Actually, this turned out to be quite trivial. Released on 2.42.3.

@gandm gandm added the released label Sep 30, 2016
@daltones
Copy link
Contributor Author

Ah! Glad it was easy. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants