grammar support for flowtype is missing

[vith]

I've got a very small start towards this in this branch that only supports type annotations in argument lists. Return type annotations break things:

Should the return types be added to the end patterns of all the varieties of function literals or is there a better way to accomplish that without so much repetition?

[gandm]

On holiday at the moment. I will review this when back.

[nmn]

+1

[gandm]

I've just committed a grammar change ( but not published) that I think gives you flowtype on functions/fat arrows. No support for let/const/var as this need thinking about. Let me know if it creates problems?

[gandm]

Strike that!! I seemed to have regressed!

[nmn]

should I not update to latest version then??

[gandm]

Yes try it - When I just tested it again I was using someone else's grammar - Doh!! Now I've set it to mine it seems OK.

Don't forget the published version is still the old one. You will have to pull the one from github.

[nmn]

hmm.. Ok let me try

[nmn]

Hey, use this file for flow-tests: https://gist.github.com/kastermester/ad79da3e48064effd82e
That with the React source code is probably the best test possible.

(i'm still trying on my own code-base, will report back shortly)

[nmn]

Ok, so I just tried it and it's not fixed. The colour has changed though.

I don't know how grammars work, but here's the problem:

(array: Array<V>): IndexedIterable<V>;

That is a valid declaration for flow. However language-babel interprets that as JSX and everything after the first <V> becomes one colour. (kind of like the colour of text in a JSX block).
Putting this comment at the end of the line seems to fix the problem:

// </> </>

(one closing tag for each angular bracket used in the line)
Which re-inforces my guess that it is being interpreted as JSX.

[gandm]

Yeah it's definitely showing as JSX. Thanks for the flow test file above. I think this is going to be pretty difficult with the current grammar. I thought that templates may be an issue. Leave it with me.

[nmn]

Thanks!

[gandm]

@nmn, @vith - Just rolled out 0.11.0 with support for flowtype. See #39 and #40 for known problems.

Let me know if you have any issues.