Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting "Disable when no Bablerc File in Path" does not disable the package #58

Closed
AddictArts opened this issue Sep 3, 2015 · 4 comments

Comments

@AddictArts
Copy link

The grammars are still enabled, is it possible to have a disable for the grammars? It can conflict with other grammars that provide the same function through a different scope.

@gandm
Copy link
Owner

gandm commented Sep 3, 2015

No it's not possible. I'm interested to know what the conflict is?
I guess you prefer other JavaScript grammars so the only suggestions I can make is either i) fork my repo and remove the grammar and use that or just remove the grammar from the downloaded package or ii) use https://atom.io/packages/file-types and associate a grammar with a file type/directory. EDIT: Thought the package could do directories but it can't!

@AddictArts
Copy link
Author

It conflicted for me with https://atom.io/packages/language-javascript-jsx, actually it won over that one, maybe the order they were applied. That package has a scope name source.js.subtlegradient and the built in source.js. I was able to use file-types to set jsx to source.js, thanks. Maybe default to File Types: es6, babel and let people add js, and jsx or turn off js and jsx? Atom's language-js is what I prefer for js and jsx. Thanks for looking at this.

@gandm
Copy link
Owner

gandm commented Sep 3, 2015

No problem. If you are using the atom provided language-javascript package for jsx then you aren't using language-Babel for the transform of JSX, so that should be ok. I'm sure you are aware Babel is now the standard jsx transform tool. http://facebook.github.io/react/blog/2015/06/12/deprecating-jstransform-and-react-tools.html

@gandm gandm closed this as completed Sep 3, 2015
@AddictArts
Copy link
Author

Yes I am aware of that babel is the official or standard jsx transform tool. I looked at just removing the grammar, but the save event uses that to fire the transpile. I could change it to the grammar I prefer, but it would be nice to config this. I tried adjusting the theme and you can't control the colors of things like the keys, so I prefer the second attachment to the first and prefer to avoid editing language-babel.less. Thanks for the help.

1
2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants