-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting "Disable when no Bablerc File in Path" does not disable the package #58
Comments
No it's not possible. I'm interested to know what the conflict is? |
It conflicted for me with https://atom.io/packages/language-javascript-jsx, actually it won over that one, maybe the order they were applied. That package has a scope name source.js.subtlegradient and the built in source.js. I was able to use file-types to set jsx to source.js, thanks. Maybe default to File Types: es6, babel and let people add js, and jsx or turn off js and jsx? Atom's language-js is what I prefer for js and jsx. Thanks for looking at this. |
No problem. If you are using the atom provided language-javascript package for jsx then you aren't using language-Babel for the transform of JSX, so that should be ok. I'm sure you are aware Babel is now the standard jsx transform tool. http://facebook.github.io/react/blog/2015/06/12/deprecating-jstransform-and-react-tools.html |
Yes I am aware of that babel is the official or standard jsx transform tool. I looked at just removing the grammar, but the save event uses that to fire the transpile. I could change it to the grammar I prefer, but it would be nice to config this. I tried adjusting the theme and you can't control the colors of things like the keys, so I prefer the second attachment to the first and prefer to avoid editing language-babel.less. Thanks for the help. |
The grammars are still enabled, is it possible to have a disable for the grammars? It can conflict with other grammars that provide the same function through a different scope.
The text was updated successfully, but these errors were encountered: