Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added shouldPass validation #7

Merged
merged 1 commit into from Apr 18, 2021

Conversation

anotherpit
Copy link
Contributor

Hi, @ganeshrvel! Thanks for the library. I love its Flutter- and UI-agnostic design and composability of the rules. Plays really well with state management in my project. The only thing I was missing was ability to use my own custom validation functions for some not-so-typical checks. So here goes the pull request with this feature.

@ganeshrvel
Copy link
Owner

Wow.. let me check this.

Thank you!!

@anotherpit
Copy link
Contributor Author

@ganeshrvel Are there any news on this?

@ganeshrvel
Copy link
Owner

Hi, @anotherpit i have reviewed your pr. Could you edit the merge branch from master to release/2.0.0? I have release the version update after a few more cleanup.

Thanks for the PR.!

@anotherpit anotherpit changed the base branch from master to release/2.0.0 April 18, 2021 14:52
@anotherpit
Copy link
Contributor Author

@ganeshrvel OK, I've switched the base to release/2.0.0, but didn't merge any of your changes to my branch yet, and didn't rerun tests. If you're OK to merge it as is, that's fine. Otherwise I'll give it a look later.

@ganeshrvel
Copy link
Owner

It's just README updates in this branch. I will merge!

@ganeshrvel ganeshrvel merged commit 1052077 into ganeshrvel:release/2.0.0 Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants