Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testing through GH Actions #2

Open
rbott opened this issue Sep 26, 2023 · 1 comment
Open

Add testing through GH Actions #2

rbott opened this issue Sep 26, 2023 · 1 comment

Comments

@rbott
Copy link
Member

rbott commented Sep 26, 2023

We should add at least some sort of testing step to validate Pull Requests through github actions. Adding unit tests will probably require quite some refactoring and yield only small result.

I would instead vote for an end-to-end test as a start.
This would include the follwing steps:

  1. start a ganeti vcluster (see this repository)
  2. run prometheus-ganeti-exporter
  3. validate that data from the vcluster is exposed

This way we learn at least if the code is somewhat working. Any opinions on this?

@rbott
Copy link
Member Author

rbott commented Oct 2, 2023

This PR will create basic Docker images to run pylint against the current codebase. Once this has been merged, I will open a PR with a GH Action step to this repository so we get at least a very basic check of the code.

We can improve from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant